Commit Graph

1206 Commits

Author SHA1 Message Date
0e7a692831 XdgToplevel: validate move/resize request serial
Currently we only support interactive move/resize with the pointer,
touch and tablet tool support are TODO.

Validate the serial here to ensure we don't start a pointer move/resize
in response to the client attempting to start a move/resize with
touch/tablet tool.

This fixes an assertion failure that the pointer's cursor is not hidden
during move/resize, which is how the issue was discovered. Another win
for assertions :)
2024-03-15 15:24:46 +01:00
1b63c463a7 security-context: implement protocol
Sensitive Wayland protocols such as wlr_screencopy and wlr_data_control
(clipboard managment) are now blocked by default inside security
contexts (e.g. flatpak 1.15.6 or later).

User configuration of the allowlist/blocklist is TODO.
2024-03-15 14:47:43 +01:00
e143cdeca9 pointer-gestures: move to input manager
We definitely should not create duplicates of the global for each seat.

Not that we really support multi-seat yet, but someday.
2024-03-15 13:25:02 +01:00
451387a4a9 Server: remove all listeners on deinit() 2024-03-14 13:42:14 +01:00
388c95d2e9 RuleList: eliminate "self" naming convention 2024-03-14 13:07:58 +01:00
8764b82da5 Vector: eliminate "self" naming convention 2024-03-14 13:06:29 +01:00
37d9d6e725 Switch: eliminate "self" naming convention 2024-03-14 13:04:41 +01:00
0131d4670d SwitchMapping: eliminate "self" naming convention 2024-03-14 13:02:38 +01:00
82a40725f9 Control: eliminate "self" naming convention 2024-03-14 13:01:49 +01:00
3077074329 Mode: eliminate "self" naming convention 2024-03-14 13:00:15 +01:00
b9dde3c49b LayoutDemand: eliminate "self" naming convention 2024-03-14 12:59:42 +01:00
c3cee0b91f PointerMapping: eliminate "self" naming convention 2024-03-14 12:58:50 +01:00
278865065b StatusManager: eliminate "self" naming convention 2024-03-14 12:57:23 +01:00
1d8bca24ae SeatStatus: eliminate "self" naming convention 2024-03-14 12:55:54 +01:00
4a259d322b InputConfig: eliminate "self" naming convention 2024-03-14 12:53:09 +01:00
b65e4f6b17 idle-inhibit: fix naming, eliminate "self" naming convention
Also add missing copyright headers
2024-03-14 12:51:34 +01:00
b0d4610999 LayoutManager: eliminate "self" naming convention 2024-03-14 12:40:26 +01:00
b7c53ceda7 Config: eliminate "self" naming convention 2024-03-14 12:40:13 +01:00
6c3f851464 Keyboard: eliminate "self" naming convention 2024-03-14 12:35:21 +01:00
f02d26c533 InputManager: eliminate "self" naming convention 2024-03-14 12:34:28 +01:00
693a2b0dda XwaylandOverrideRedirect: eliminate "self" naming convention 2024-03-14 12:29:49 +01:00
28f30b2571 Mapping: eliminate "self" naming convention 2024-03-14 12:22:15 +01:00
904b623b84 XwaylandView: eliminate "self" naming convention 2024-03-14 12:21:21 +01:00
0e2cac08df XdgToplevel: eliminate "self" naming convention 2024-03-14 12:19:36 +01:00
2eb2a13284 Cursor: eliminate "self" naming convention 2024-03-14 12:08:24 +01:00
99a99b72e7 View: eliminate "self" naming convention 2024-03-14 12:07:27 +01:00
d8f041c96f Output: eliminate "self" naming convention 2024-03-14 12:06:33 +01:00
267aa9a9b5 Seat: eliminate "self" naming convention 2024-03-14 12:05:36 +01:00
8a9b07ae4b Root: eliminate "self" naming convention 2024-03-14 12:04:15 +01:00
aadb92dc0b Layout: eliminate "self" naming convention 2024-03-14 12:02:32 +01:00
dabf7e9e97 Server: clean up initialization
This ended up uncovering a latent bug in the IdleInhibitorManager
initialization code, not sure how that ever worked.
2024-03-14 11:55:23 +01:00
859578873a mailmap: map Hugo's old emails to new one 2024-03-14 11:12:30 +01:00
81f5b970e6 completions: Add missing completions
Added:
  * close (bash)
  * focus-output args: up right down left (bash,fish,zsh)
  * send-to-output args: up right down left (bash,fish,zsh)
  * default-attach-mode (bash,fish)
  * output-attach-mode (bash,fish)
  Zsh only as I don't know how does it works in other shell and so
  it's still need to be done.
    * send-to-output flags: -current-tag
    * keyboard-layout flags: -rules -model -variant -options
    * [un]map-switch, lid -> close|open and tablet -> on|off

Fixed:
  * rule-add|list-rules actions, rename tag to tags (bash,fish,zsh)

Some descriptions probably need to be changed with new args like up,
right..
2024-03-14 11:12:29 +01:00
4e48d68485 View: restore to previous output on reconnect 2024-03-14 11:07:15 +01:00
fecfa89a9a View: fix SSD desync on consecutive timeouts
If multiple consecutive transaction timeouts occur it is possible for
the SSD borders to become temporarily desynchronized with the size of
the rendered surface.

This is especially noticeable during interactive resize of mpv.

For details on cause/fix, see the new comment in the code.
2024-03-13 15:57:01 +01:00
b0dc5f7294 View: improve transaction timeout handling
This fixes a possible assertion failure in Cursor.updateState() when
trying to start move/resize of a xdg toplevel with the timed_out or
timed_out_acked configure_state.

This also generally improves the UX of transaction timeouts as all
state except for the size change is now applied immediately.
2024-03-13 12:28:08 +01:00
46dbbe9799 deps: switch to codeberg upstreams, update 2024-03-12 14:12:54 +01:00
c474be1537 build: require wlroots version 0.17.2
This fixes a crash that users have hit fairly often in the wild using
Xwayland and allows us to remove an ugly workaround for another issue.
2024-03-11 19:14:37 +01:00
49a779b24d tablet-v2: implement tablet tool support
There is not any pointer emulation for tablet tool input. This means
that only clients implementing the tablet-v2 protocol will be able to
process tablet tool input.

Tablet pad support is TODO
2024-03-11 15:05:42 +01:00
ac655593f3 View: remove faulty assertion
This assertion does not consider that a view may be visible on an output
despite no view on that output having focus due to a differnt output
currently having focus.

I don't see any clean way to fix the assert, so just remove it.
2024-03-09 13:47:36 +01:00
4a65af667e Root: reduce transaction timeout to 50ms
The current value of 200ms is too long and makes river feel very slow
when it it hit due to an application being very slow/frozen.

The new timeout of 50ms seems to be rarely hit in practice even on
slower hardware such as my old Thinkpad x220. When it is hit the system
feels much more responsive than when the 200ms timeout is hitdespite the
guilty application window potentially being visible in the wrong
location/size a bit longer.
2024-03-08 12:21:02 +01:00
f803ca6274 View: clean up attach-mode code, add assert 2024-03-08 11:56:34 +01:00
26210b2be5 View: Add attachRelative function
This is used for the above/below attach-modes introduced in d71bebc.

Also remove redundant focusedIndex function in Output.PendingState.
2024-03-08 11:56:34 +01:00
50d4f25eee build: enable frame pointers in release safe
These are by default only enabled for debug builds but give a higher
chance of getting a usable stack trace out of bug reports as Zig's
builtin stack trace dumping code doesn't handle their absence well in
all cases yet. The cost should be negligible as river is not CPU-bound.
2024-03-07 16:46:42 +01:00
726ee2e7ca completions/zsh: Update attach-modes 2024-03-05 17:53:16 +01:00
d71bebc032 command/attach-modes: above and below options 2024-03-05 17:53:16 +01:00
f6cc4de884 example/init: Replace light with brightnessctl
Change screen backlight brightness command to brightnessctl(1) as
light(1) repo has been deleted.
2024-03-05 12:05:55 +01:00
c4d6fab902 mailmap: map Isaac's old email to the new one
I assume that I'm not the only one who has changed/will change their
email over the years of river development, so this seems like a
reasonable thing to have.
2024-03-04 14:06:53 +01:00
60f4cafad0 river: only expose xwayland_shell_v1 to Xwayland
This is a private protocol only intended for the Xwayland client.
2024-03-02 17:37:04 +01:00
0eacde7d01 deps: update to latest zig-wayland and zig-wlroots 2024-03-02 17:36:47 +01:00