1268 Commits

Author SHA1 Message Date
Isaac Freund
3ff620fae3
build: bump version to 0.3.2 2024-05-20 12:14:13 +02:00
Isaac Freund
25675e4fcb
ci: drop FreeBSD CI for now
There is no FreeBSD tarball from ziglang.org and FreeBSD itself has not
yet updated their Zig package to 0.12.0. This commit should be reverted
when a good way is found to obtain Zig 0.12.0 for the FreeBSD CI.

(cherry picked from commit 7fdba05b8249b10d10a2c64c1175429539c01af1)
2024-05-20 12:13:18 +02:00
Isaac Freund
b1bac96731
build: switch to the Zig package manager
No more git submodules!

(cherry picked from commit 958f8798b6fdfab40aa29e1538827fa74e833a1c)
2024-05-20 12:13:18 +02:00
Isaac Freund
9cbd66f543
build: add -Dno-llvm build option
(cherry picked from commit 045ee7bd25963d1a12635fd83af0629474c5575f)
2024-05-20 12:07:52 +02:00
Isaac Freund
312465e0cb
build: update to Zig 0.12
(cherry picked from commit 033cad47bf63f2914865c19fc10b4dc991007515)
2024-05-20 12:07:52 +02:00
Isaac Freund
c757e1b33e
build: bump version to 0.3.2-dev 2024-05-18 17:43:46 +02:00
Isaac Freund
6a2eeba9ed
bulid: bump version to 0.3.1 2024-05-18 17:09:03 +02:00
Isaac Freund
a019045a16
PointerConstraint: remove overly tight assert 2
This is a second copy of the same assert that was removed in the last
commit. It should have been removed by that commit as well but was
overlooked.

(cherry picked from commit 680cb8ef699f89cd7ce0b613221e073b534c22c5)
2024-05-18 17:07:48 +02:00
Isaac Freund
7b42c38276
PointerConstraint: remove overly tight assert
This assert is incorrect if Xwayland is enabled and an Override Redirect
window steals the keyboard focus from the parent surface.

It also seems likely to be hit if a Wayland client attempts to use a
pointer constraint on a subsurface. I don't think a pointer constraint
on a subsurface is likely to work entirely correctly and I don't know of
any Wayland clients that try such a thing. We can't let them crash river
by trying though.

(cherry picked from commit 5d1fc034bc6aedc340671d5de76add308effd2e8)
2024-05-18 17:07:48 +02:00
Isaac Freund
fa077d31b4
InputPopup: fix minor issues, simplify code
(cherry picked from commit c75d32c88b2fda71b543b72e02117cdfb7693e2e)
2024-05-18 13:41:28 +02:00
Isaac Freund
cc5a249e9e
TextInput: ignore enable requests without focus
(cherry picked from commit b35a40b9dfa3e70dbdc11e8383c584164b475420)
2024-05-18 13:41:28 +02:00
Isaac Freund
84ec97aff2
InputPopup: fix naming
(cherry picked from commit ba6023e38a965d80788a3de33d6c19968db03647)
2024-05-18 13:41:28 +02:00
leviathan
7db9ade574
input-method-v2: Implement popups
(cherry picked from commit 74baf7225ad95f8288f5dc1fe50345425cd62f71)
2024-05-18 13:41:28 +02:00
Isaac Freund
9c56eb051f
Server: fix filtering of newly created globals
Fixes: https://codeberg.org/river/river/issues/1068
(cherry picked from commit b5a80c7b9b34a42b2546d8724498b0b6d59f6cec)
2024-05-18 13:41:28 +02:00
ymcx
9b0e90cdb4
command/swap: fix cursor warp on focus change
(cherry picked from commit bed50f0dd2099e06c85f0fd0cc3bbdb10f3c9353)
2024-05-18 13:41:28 +02:00
Isaac Freund
cfb67b9e7a
Keyboard: fix redundant leave/enter on creation
Currently if a second keyboard input device is created river will send
a wl_keyboard.leave event immediately followed by a wl_keyboard.enter
event. This serves no purpose and can confuse clients, in particular due
to fctix creating/destroying virtual keyboards on focus change.

Fixes: https://codeberg.org/river/river/issues/1062
References: https://github.com/fcitx/fcitx5/issues/1044
(cherry picked from commit 1e3ef88bd573e4940f7e9dcffdbf119161473e4d)
2024-05-18 13:41:05 +02:00
Isaac Freund
717894b007
Cursor: don't hide while pointer constraint active
Fixes: https://codeberg.org/river/river/issues/1053
(cherry picked from commit f66eec92482dabb782d5457caef4ca1dbfb82b59)
2024-05-18 13:30:59 +02:00
Alex Mirrlees-Black
442913fa82
input: change ScrollFactor and MapToOutput to align with other options
(cherry picked from commit 5262a4c5a61f547acd29560f1af9cf342b9958ae)
2024-04-27 13:39:47 +02:00
Alex Mirrlees-Black
b5964d7f1f
input: fix scroll-factor resetting if unspecified
(cherry picked from commit bd5da261eb584fd40e0b1e1609d7db5faa0ae517)
2024-04-27 13:39:47 +02:00
Alex Mirrlees-Black
33cc85d5ef
input: prevent duplicate input configs
(cherry picked from commit 5fbf174c3644a64ee217c732190b16ab9b65120a)
2024-04-27 13:39:47 +02:00
Isaac Freund
b2c4d38e09
XdgToplevel: update clip on geometry x/y change
Currently if a client commits a geometry with a different x/y value but
does not change the width/height we might not update the clip
coordinates of the surface tree, potentially causing part of the surface
to be unintentionally clipped off.

To fix this, check for change in geometry x/y as well as width/height on
commit if the client is not currently part of an ongoing transaction.

Firefox for example it seems may respond to a configure non-atomically
with multiple commits:

1. commit new buffer and new geometry of a new width/height.
2. commit again with the same width/height but a new geometry x/y.

I don't think this is technically a bug but it doesn't seem like the
most efficient way to do things. I think this may also cause imperfect
frames. In any case, this should no longer cause river to crop off part
of firefox's surface.

(cherry picked from commit 9bbd34a0e31b6d429df2d39a59d8990a9585e186)
2024-04-27 13:39:47 +02:00
Isaac Freund
dbfaa05a67
XdgToplevel: don't update geometry if configure inflight
(cherry picked from commit d1dc873408d2b45c53dfc174ad0eadfe15a2355e)
2024-04-27 13:39:47 +02:00
Isaac Freund
822690146d
build: bump version to 0.3.1-dev 2024-04-19 14:00:29 +02:00
Isaac Freund
d3178ae13f
build: bump version to 0.3.0 2024-04-16 14:03:17 +02:00
Isaac Freund
f9e52f32bf
docs: remove website url at top of readme
Codeberg lets me put this by the repository description.
2024-04-16 13:51:46 +02:00
Isaac Freund
6bae8efe01
docs: freshen up readme with text from website 2024-04-16 13:48:39 +02:00
Isaac Freund
df5cb5dfe8
input: minor fixes and cleanups for scroll-factor 2024-04-16 13:26:01 +02:00
István Donkó
8a3018a311
input: add scroll-factor configuration 2024-04-16 13:25:40 +02:00
Isaac Freund
4a019142be
layer-surface: close if exclusive zones too large
It seems layer-shell clients such as waybar can commit bogus exclusive
zones larger than the width/height of the output. While this client
behavior is questionable at best, it must not cause river to crash or
otherwise misbehave.

Therefore, close layer surfaces causing the usable (not exclusive zone)
area of an output to be reduced below half of the width/height.
2024-04-16 12:18:39 +02:00
Isaac Freund
70ad2af8f4
docs: update URL in man pages
Also remove the redundant URL in the footer and the redundant
"General Commands Manual" text (scdoc adds that by default based on the
section it seems).
2024-04-15 11:23:05 +02:00
Isaac Freund
14e941bae1
docs: redefine Code of Conduct scope 2024-04-09 14:18:47 +02:00
Isaac Freund
86d142aa47
logo: make readme logo bigger on small displays
The correct way to do this would be to use the max-width css attribute,
but codeberg seems to strip that when converting markdown to html.

The new value of 600em looks almost identical to 50% on large screens
and looks a lot better on small (mobile) screens.
2024-04-09 10:41:34 +02:00
Isaac Freund
7974bfdb7d
docs: fix another broken link in the coc
The markdown generation of the upstream Contributor Covenant page seems
to have some issues.
2024-04-09 09:43:02 +02:00
Isaac Freund
9a04462cdf
docs: fix broken link in coc 2024-04-09 09:41:38 +02:00
Isaac Freund
06c13197bb
docs: add Code of Conduct 2024-04-09 08:57:17 +02:00
Isaac Freund
3e306ecfbf
river: raise the file descriptor limit 2024-04-08 16:24:51 +02:00
Isaac Freund
94828474b0
View: add more assertions around destruction
This should make leaks like the one fixed by the previous commit harder
to write.
2024-04-08 15:19:12 +02:00
Isaac Freund
a374c6ab84
Root: fix leak on view destroy
This leaks memory and possibly an fd currently whenever a view is
destroyed.
2024-04-08 15:02:55 +02:00
Isaac Freund
b0e54c6396
Output: fix possible assertion failure on enable
Currently if we disable an output due to a wlr-output-power-management
protocol request we do not update Output.lock_render_state properly.

This is fine if the output is also re-enabled using the
wlr-output-power-management protocol but causes an assertion failure
if it is re-enabled using wlr-output-management instead.
2024-04-08 13:34:47 +02:00
Isaac Freund
3594fe501e
View: fix assertion failure if focused while destroying
Also clean up this code a bit, it's no longer necessary to split these
one line functions out into separate files as Zig's conditional
compilation support has improved since these functions were originally
written.
2024-04-08 12:54:05 +02:00
Isaac Freund
93f9eb8e5e
logo: use adaptive color/no background for readme
This looks nicer with dark themes. Light themes should be effectively
unchanged.
2024-04-08 12:28:46 +02:00
Isaac Freund
36d8e90a54
View: always check if current.output is null
This field being nullable at all is code smell. I think what needs to
happen here long term is for a proper separation of "window management
output" and "physical output" as concepts and integration outputs into
the transaction system.

That's a much larger change and I don't want to cause that amount of
code churn just before a release though.
2024-04-03 17:18:54 +02:00
Isaac Freund
8b8ac27c45
ci: migrate to codeberg 2024-04-01 22:28:23 +02:00
Isaac Freund
8d59622ae1
docs: fix typo in previous commit 2024-03-26 15:23:49 +01:00
Isaac Freund
1946f284d5
docs: update README stability disclaimer 2024-03-26 15:16:49 +01:00
Isaac Freund
c4877de3ca
logo: add an official river logo
This logo is based on original raster images designed by Karl Felix
Schewe (@kardwen on codeberg/github). I created a modified svg version
from scratch in inkscape. I've included several variations (with text,
with text and a background) for various use cases.

The versions with text use the Dongle font [1] which is released under
the OFL and therefore free for us to use in the logo without
acknowledgement according to [2].

[1]: https://github.com/yangheeryu/Dongle
[2]: https://openfontlicense.org
2024-03-26 13:24:53 +01:00
tiosgz
198351794b
Keyboard: ignore multiple presses of a key
I have managed to crash river (because the relevant assertion was wrong)
on this using fcitx5 (5.1.8) and anthy with the following sequence of
key events on a physical keyboard (every line followed by releasing
everything):
    super-; (my shortcut to enable anthy)
    shift-letter (fcitx doesn't release shift on its virtual keyboard)
    escape
    shift (fcitx sends another press event)
The failure to release shift is not the only weirdness happening, but
it's what eventually lead to the assertion failure.
2024-03-26 10:48:28 +01:00
Isaac Freund
7ceed0d093
docs: update release urls for codeberg migration 2024-03-25 20:12:29 +01:00
Isaac Freund
4d0315b565
docs: update wiki url 2024-03-25 19:56:46 +01:00
Isaac Freund
19133422c1
codeberg: maybe fix issue template take 2 2024-03-25 19:45:52 +01:00