Zander671/river
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

XdgToplevel: tweak fullscreen state policy

Browse Source 
Currently river only sends the fullscreen state to a maximum of one
toplevel per output at a time and switching tags such that the
fullscreen toplevel is not visible causes the fullscreen state to be
removed.

This may be technically correct, but it causes issues when programs like
firefox trigger animations on fullscreen state change.

This commit returns river's policy here to what we did back in 0.2 and
leaves the xdg_toplevel fullscreen state set regardless of whether or
not the toplevel is currently rendered as fullscreen or if there are
other fullscreen toplevels.
This commit is contained in:
Isaac Freund 2023-11-03 17:16:04 +01:00
parent 59c9842c8f
commit 642f9b7ae0
No known key found for this signature in database
GPG Key ID: 86DED400DDFD7A11
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
river/XdgToplevel.zig
View File

@ -104,9 +104,6 @@ pub fn configure(self: *Self) bool {
const inflight = &self.view.inflight; const inflight = &self.view.inflight;
const current = &self.view.current; const current = &self.view.current;
const inflight_fullscreen = inflight.output != null and inflight.output.?.inflight.fullscreen == self.view;
const current_fullscreen = current.output != null and current.output.?.current.fullscreen == self.view;
const inflight_float = inflight.float or (inflight.output != null and inflight.output.?.layout == null); const inflight_float = inflight.float or (inflight.output != null and inflight.output.?.layout == null);
const current_float = current.float or (current.output != null and current.output.?.layout == null); const current_float = current.float or (current.output != null and current.output.?.layout == null);
@ -116,7 +113,7 @@ pub fn configure(self: *Self) bool {
if (inflight.box.width == current.box.width and if (inflight.box.width == current.box.width and
inflight.box.height == current.box.height and inflight.box.height == current.box.height and
(inflight.focus != 0) == (current.focus != 0) and (inflight.focus != 0) == (current.focus != 0) and
inflight_fullscreen == current_fullscreen and inflight.fullscreen == current.fullscreen and
inflight_float == current_float and inflight_float == current_float and
inflight.ssd == current.ssd and inflight.ssd == current.ssd and
inflight.resizing == current.resizing) inflight.resizing == current.resizing)
@ -126,7 +123,7 @@ pub fn configure(self: *Self) bool {
_ = self.xdg_toplevel.setActivated(inflight.focus != 0); _ = self.xdg_toplevel.setActivated(inflight.focus != 0);
_ = self.xdg_toplevel.setFullscreen(inflight_fullscreen); _ = self.xdg_toplevel.setFullscreen(inflight.fullscreen);
if (inflight_float) { if (inflight_float) {
_ = self.xdg_toplevel.setTiled(.{ .top = false, .bottom = false, .left = false, .right = false }); _ = self.xdg_toplevel.setTiled(.{ .top = false, .bottom = false, .left = false, .right = false });