92242f0b9d
hyprland: fix a data race at startup between sockets 1 and 2
...
`Workspaces::*` and `IPC::startIPC` may both call `getSocketFolder` at the same time.
This randomly causes crashes and/or corruption of the socket path.
Typical crash A:
[2024-10-16 07:42:09.987] [info] Hyprland IPC starting
malloc(): unaligned tcache chunk detected
[2024-10-16 07:42:09.987] [error] Hyprland IPC: Unable to connect?
Thread 1 "waybar" received signal SIGABRT, Aborted.
(gdb) bt
#0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
(omitted for brievety)
#9 0x00007ffff64ae745 in operator new (sz=sz@entry=296) at /usr/src/debug/gcc/gcc/libstdc++-v3/libsupc++/new_op.cc:50
#10 0x00007ffff65ab1f1 in std::filesystem::__cxx11::path::_List::_Impl::copy (this=0x555555a23350) at /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++17/fs_path.cc:249
#11 0x00007ffff65ab3bd in std::filesystem::__cxx11::path::_List::_List (this=0x7fffffff9d30, other=<optimized out>) at /usr/src/debug/gcc/gcc-build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/unique_ptr.h:454
#12 0x00005555556f4ab1 in waybar::modules::hyprland::IPC::getSocket1Reply(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
#13 0x00005555556f5e3d in waybar::modules::hyprland::IPC::getSocket1JsonReply(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
#14 0x000055555571289c in waybar::modules::hyprland::Workspaces::setCurrentMonitorId() ()
Typical crash B:
[2024-10-16 10:01:15.859] [info] Hyprland IPC starting
[2024-10-16 10:01:15.859] [info] Loading persistent workspaces from Hyprland workspace rules
Thread 8 "waybar" received signal SIGSEGV, Segmentation fault.
(gdb) bt
#0 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_S_copy
(__d=0x5555558fbca8 "/", __s=0x2973961a26d35726 <error: Cannot access memory at address 0x2973961a26d35726>, __n=1)
at /usr/src/debug/gcc/gcc-build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/basic_string.h:433
(omitted for brievety)
#15 waybar::modules::hyprland::IPC::getSocketFolder[abi:cxx11](char const*)
(instanceSig=0x7fffffffe604 "4520b30d498daca8079365bdb909a8dea38e8d55_1729051218_1982280648") at ../src/modules/hyprland/backend.cpp:41
#16 0x000055555564230f in waybar::modules::hyprland::IPC::startIPC()::{lambda()#1}::operator()() const ()
at ../src/modules/hyprland/backend.cpp:70
#17 0x00007ffff64e1c34 in std::execute_native_thread_routine (__p=0x5555558119c0) at /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++11/thread.cc:104
#18 0x00007ffff62a339d in start_thread (arg=<optimized out>) at pthread_create.c:447
2024-10-17 06:46:07 -04:00
0e03c7a811
fix a segfault on signals received after main returns
...
The waybar process does not exit instantaneously.
Signals may be recevied after main has started freeing resources.
When a worker thread is in `fgets` this time window can last forever.
An easy way to duplicate the crash is pressing ^C twice with a Hyprland module.
Thread 1 "waybar" received signal SIGSEGV, Segmentation fault.
spdlog::sinks::sink::should_log (this=0x5f620b542ca5,
msg_level=spdlog::level::info)
at /usr/src/debug/spdlog/spdlog-1.14.1/include/spdlog/sinks/sink-inl.h:13
13 return msg_level >= level_.load(std::memory_order_relaxed);
(gdb) p $_siginfo._sifields._sigfault.si_addr
$1 = (void *) 0x5f620b542cad
2024-10-16 10:04:04 -04:00
280f11e247
Merge pull request #3658 from Alexays/update_flake_lock_action
2024-10-01 07:42:02 +02:00
95eaffcfb1
flake.lock: Update
...
Flake lock file updates:
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/4f807e8940284ad7925ebd0a0993d2a1791acb2f?narHash=sha256-IiA3jfbR7K/B5%2B9byVi9BZGWTD4VSbWe8VLpp9B/iYk%3D' (2024-09-11)
→ 'github:NixOS/nixpkgs/06cf0e1da4208d3766d898b7fdab6513366d45b9?narHash=sha256-S5kVU7U82LfpEukbn/ihcyNt2%2BEvG7Z5unsKW9H/yFA%3D' (2024-09-29)
2024-10-01 00:11:21 +00:00
e7b2d33d99
Merge pull request #3637 from TripleTrable/backlight/add_min_brightness
...
#2275 Backlight: Add minimum brightness
2024-09-30 09:17:15 +02:00
281911c9b3
Merge pull request #3652 from khaneliman/flake
2024-09-29 09:06:40 +02:00
e53497bab6
.github/workflows: allow forks to manually run flake lock update
2024-09-28 13:21:55 -05:00
a1adf6847f
Merge pull request #3650 from khaneliman/nix
2024-09-28 20:16:12 +02:00
6322fa28f3
Merge pull request #3651 from khaneliman/github
2024-09-28 20:15:50 +02:00
e394485857
.github/workflows: don't run on forks
2024-09-28 12:55:47 -05:00
edab49f291
nix/default: cava bump
2024-09-28 12:41:10 -05:00
486b99c22f
Merge pull request #3646 from LukashonakV/cava_bump
2024-09-28 07:54:57 +02:00
e46a1c6bfc
cava bump
...
Signed-off-by: Viktar Lukashonak <myxabeer@gmail.com >
2024-09-28 00:57:02 +03:00
d684a6de21
Backlight: Set default to 0 to prevent breaking existing setups
2024-09-25 16:37:21 +02:00
cad18f39f5
Merge pull request #3640 from mslxl/master
...
nix: remove patches from downstream
2024-09-25 14:18:52 +02:00
47f767b0ee
Backlight: Add documentation for min-brightness
2024-09-25 06:24:24 +02:00
04bda9f443
Backlight: Add minimum brightness
...
As currently it is possible to turn the brightness to zero which may not
be desirable, this patch add a configurable brightness check.
2024-09-25 06:24:03 +02:00
c88a86f510
nix: remove patches from downstream
...
The patches is the modification of downstream, it should not affect upstream. Any changes of upstream would caused patch fail.
2024-09-25 10:01:41 +08:00
07f75e303c
Merge pull request #3632 from LukashonakV/ISSUE#3383
...
Fix: 3383. Clock. Default value for cldYearShift_ = 1900/01/01
2024-09-23 17:45:03 +02:00
b4e97eb2f4
FreeBSD format fix
...
Signed-off-by: Viktar Lukashonak <myxabeer@gmail.com >
2024-09-23 16:06:50 +03:00
773b1d4806
Default value for cldYearShift_ = 1900/01/01
...
Signed-off-by: Viktar Lukashonak <myxabeer@gmail.com >
2024-09-23 15:51:01 +03:00
21af48fdc9
chore: lint
2024-09-19 17:31:07 +02:00
b5395f4e6f
Merge pull request #3523 from S0nter/master
...
cava: Add format_silent option and css triggers
2024-09-19 17:30:34 +02:00
3462769fc1
Merge branch 'Alexays:master' into master
2024-09-19 14:45:33 +00:00
ac1a42291d
Merge pull request #3617 from lukasfink1/fix-custom-format-bug
...
fix(custom): stop mixing manual and automatic arg indexing
2024-09-19 13:50:45 +02:00
a3e7031fe2
Fix formatting
2024-09-18 17:30:55 +02:00
254111ff91
Improve error message for mixed arg indexing in format string
2024-09-18 17:28:58 +02:00
de170fa579
Update documentation
2024-09-17 02:56:38 +02:00
83992d29a0
Fix formatting
2024-09-17 00:39:33 +02:00
3bb3c2d23f
fix(custom): stop mixing manual and automatic arg indexing
...
The current documentation for the custom module suggests mixing manual
(`{icon}`) and automatic (`{}`) indexing of format args. Newer versions
of the fmt library seem to not support this anymore (see issue #3605 ).
This commit introduces a name for the `text` output of the script, so
that `{text}` can now be used instead of `{}` in the configuration.
2024-09-17 00:13:23 +02:00
ff66b5dd57
Update waybar-cava man page
2024-09-16 17:47:10 +00:00
9e8ebe668d
Merge branch 'Alexays:master' into master
2024-09-16 17:11:32 +00:00
9cfb1e38fa
Merge pull request #3528 from alebastr/sway-scene-fixes
...
Fixes for Sway modes and wlr_scene support
2024-09-16 14:44:17 +02:00
ae997ad73b
Merge pull request #3613 from ThatOneCalculator/fix/3612
2024-09-16 08:09:13 +02:00
085a1ede97
fix: use app_identifier itself in AAppIconLabel if it's an absolute path
2024-09-15 21:28:15 -03:00
0d02f6877d
Merge pull request #3604 from alebastr/tray-fix
2024-09-15 09:04:58 +02:00
e0be3ac178
flake.lock: Update
...
Flake lock file updates:
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/71e91c409d1e654808b2621f28a327acfdad8dc2?narHash=sha256-GnR7/ibgIH1vhoy8cYdmXE6iyZqKqFxQSVkFgosBh6w%3D' (2024-08-28)
→ 'github:NixOS/nixpkgs/4f807e8940284ad7925ebd0a0993d2a1791acb2f?narHash=sha256-IiA3jfbR7K/B5%2B9byVi9BZGWTD4VSbWe8VLpp9B/iYk%3D' (2024-09-11)
2024-09-14 23:09:16 -07:00
45fec7bcbb
Revert "change layer for mode invisible to nullopt"
...
Previous commit should have a better workaround for #3211 .
This reverts commit b61ea62732
2024-09-14 22:43:07 -07:00
7b23d58684
fix(bar): force commit for occluded surfaces
...
All the mode or visibility changes require `wl_surface_commit` to be
applied. gtk-layer-shell will attempt to force GTK to commit, but may
fail if the surface has stopped receiving frame callbacks[^1].
Thus, we could get stuck in a state where the bar is hidden and unable
to regain visibility.
To address this, a new API has been added to gtk-layer-shell,
`gtk_layer_try_force_commit`, which does `wl_surface_commit` with the
necessary safety checks to avoid corrupting GTK internal state.
Note: this change bumps gtk-layer-shell requirement to 0.9.0.
[^1]: https://github.com/wmww/gtk-layer-shell/issues/185
2024-09-14 22:43:06 -07:00
0006e4713a
fix(tray): revert ustring formatting changes
...
This reverts commit a4d31ab10d
2024-09-14 07:38:41 -07:00
f60c291b82
chore: update fmt wrap to 11.0.2
2024-09-14 07:36:23 -07:00
8e2a742042
Merge branch 'Alexays:master' into master
2024-09-13 11:31:22 +00:00
4a6af0da99
fix(bar): use overlay layer for hide and overlay modes
...
This fixes a major inconsistency with the swaybar implementation of
these modes[^1]. `overlay` layer no longer has security implications due
to a wide adoption of `ext-session-lock`, so it's safe to use.
Following config will restore the previous behavior:
```json
"modes": {
"hide": { "layer": "top" },
"overlay": { "layer": "top" }
},
```
[^1]: 2f7247e08a
2024-09-13 01:26:25 -07:00
d177969f51
chore: lint
2024-09-13 09:53:15 +02:00
59b7715309
Merge pull request #3580 from hramrach/rotate-doc
...
Clarify documentation of 'rotate' option.
2024-09-13 09:52:59 +02:00
d56dd6ee7f
chore: v0.11.0
2024-09-13 09:51:11 +02:00
1142979581
chore: lint
2024-09-13 09:43:19 +02:00
8a89706d03
Merge pull request #3551 from YaLTeR/niri
...
Add niri/workspaces, niri/window, niri/language
2024-09-13 09:41:52 +02:00
a4d31ab10d
fix: sni item fmt
2024-09-13 09:40:35 +02:00
34bfefcd2e
niri: Gate behind a meson option
2024-09-13 10:34:55 +03:00
