Zander671/river
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

view: implement frame-perfect destroy

Browse Source 
river's View objects may now outlive their wlroots counterparts so that
we can continue to render a destroyed view until the transaction is
completed.
This commit is contained in:
Isaac Freund
2020-08-20 14:35:19 +02:00
parent 59d6432332
commit fa08d85c58
6 changed files with 61 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
river/Root.zig
View File

@ -133,6 +133,11 @@ pub fn startTransaction(self: *Self) void {
while (view_it.next()) |view_node| {
const view = &view_node.view;
if (view.destroying) {
if (view.saved_buffers.items.len == 0) view.saveBuffers();
continue;
}
if (view.shouldTrackConfigure()) {
// Clear the serial in case this transaction is interrupting a prior one.
view.pending_serial = null;
@ -226,9 +231,17 @@ fn commitTransaction(self: *Self) void {
var view_tags_changed = false;
var view_it = ViewStack(View).iterator(output.views.first, std.math.maxInt(u32));
while (view_it.next()) |view_node| {
var view_it = output.views.first;
while (view_it) |view_node| {
const view = &view_node.view;
if (view.destroying) {
view_it = view_node.next;
view.destroy();
continue;
}
defer view_it = view_node.next;
if (!view.shouldTrackConfigure() and view.pending_serial != null) continue;
// Apply pending state of the view