Zander671/river
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

river: make spawn command take only one argument

Browse Source 
Currently the spawn command takes any number of arguments and naively
joins them together with spaces before passing them as the single
argument of `/bin/sh -c`. This however produces unexpected results as
soon as shell quoting gets involved in the arguments passed to spawn.
For example, running

riverctl spawn foo "bar baz"

will execute `/bin/sh -c "foo bar baz"`, unexpectedly splitting bar and
baz into separate arguments. To avoid this confusion, make the spawn
command take only a single argument, forcing the user to quote properly
to spawn multi-argument commands.
This commit is contained in:
Isaac Freund
2021-07-16 00:00:28 +02:00
parent dfa2471141
commit b7e15a8ef6
3 changed files with 17 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
doc/riverctl.1.scd
View File

@ -65,9 +65,9 @@ over the Wayland protocol.
output in any direction.
*spawn* _shell_command_
Run _shell_command_ using _/bin/sh -c_. Put single quotes around
_shell_command_ if you do not want special characters to get
interpreted by your shell before the command gets passed to _/bin/sh_.
Run _shell_command_ using `/bin/sh -c _shell_command_`. Note that
*spawn* only takes a single argument. To spawn a command taking
multiple arguments, wrapping the command in quotes is recommended.
*swap* *next*|*previous*
Swap the focused view with the next/previous visible non-floating
@ -336,9 +336,9 @@ However note that not every input device supports every property.
# EXAMPLES
Bind bemenu-run to Super+P in normal mode:
Bind Super+Enter in normal mode to spawn a *foot*(1) terminal:
riverctl map normal Mod4 P spawn bemenu-run
riverctl map normal Mod4 Enter spawn 'foot --app-id=foobar'
See also the example init script at /etc/river/init.