Zander671/river
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

idle-inhibit: fix use-after-free

Browse Source 
A user reported a crash that only reproduces when preloading a hardened
malloc implementation. From the stack trace, this use-after-free seems
to be the most likely cause. Yay hardened malloc!
This commit is contained in:
Isaac Freund 2023-01-21 14:54:14 +01:00
parent 6c7586e8d7
commit a9bfb7c924
No known key found for this signature in database
GPG Key ID: 86DED400DDFD7A11
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
river/IdleInhibitor.zig
View File

@ -28,7 +28,8 @@ fn handleDestroy(listener: *wl.Listener(*wlr.IdleInhibitorV1), _: *wlr.IdleInhib
const node = @fieldParentPtr(std.TailQueue(Self).Node, "data", self); const node = @fieldParentPtr(std.TailQueue(Self).Node, "data", self);
server.idle_inhibitor_manager.inhibitors.remove(node); server.idle_inhibitor_manager.inhibitors.remove(node);
util.gpa.destroy(node);
self.inhibitor_manager.idleInhibitCheckActive(); self.inhibitor_manager.idleInhibitCheckActive();
util.gpa.destroy(node);
} }