Zander671/kdumpst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

module-setup.sh: Bail-out if makedumpfile is not available

Browse Source 
If we don't have makedumpfile, it doesn't make sense to construct
the kdump initrd and let it be loaded; it's going to fail in the
kdump dmesg collection, during a panic event, with no clear traces
for users to diagnose the issue.

So, let's bail-out if we don't have makedumpfile, forcing the
kdump load to fail instead, which is clearly warned in journalctl.
Also, change the approach for the kdump.conf file as well, in
order to fail creating the initrd if any of the files are missing.

While at it, fix a trailing space in the module-setup.sh file.

Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
This commit is contained in:
Guilherme G. Piccoli
2022-08-01 14:27:47 -03:00
parent 2dd96e15cb
commit f92eee306a
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
module-setup.sh
View File

@ -20,7 +20,14 @@ installkernel() {
install() { install() {
# Having a valid /usr/share/kdump/kdump.conf is essential for kdump. # Having a valid /usr/share/kdump/kdump.conf is essential for kdump.
if [ ! -s "/usr/share/kdump/kdump.conf" ]; then if [ ! -s "/usr/share/kdump/kdump.conf" ]; then
return 1 logger "kdump-steamos: failed to create initrd, kdump.conf is missing"
exit 1
fi
# Also true for makedumpfile...
if [ ! -x "$(command -v makedumpfile)" ]; then
logger "kdump-steamos: failed to create initrd, makedumpfile is missing"
exit 1
fi fi
. /usr/share/kdump/kdump.conf . /usr/share/kdump/kdump.conf