From 7f212ffb73ea9c084512c0a86d254465ce3a1e84 Mon Sep 17 00:00:00 2001 From: "Guilherme G. Piccoli" Date: Fri, 25 Nov 2022 11:26:14 -0300 Subject: [PATCH] kdump-load/save-dumps: Fix some return code on errors We have been way too conservative to prevent boot flaws, returning always success even on failures. This is changed now. Signed-off-by: Guilherme G. Piccoli --- kdump-load.sh | 4 ++-- save-dumps.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kdump-load.sh b/kdump-load.sh index 39045f0..017a910 100644 --- a/kdump-load.sh +++ b/kdump-load.sh @@ -34,7 +34,7 @@ grub_update() { logger "kdump: kexec cannot work, no reserved memory in this boot..." logger "kdump: but we automatically set crashkernel for next boot." - exit 0 + exit 0 # this is considered a successful run fi if [ "$1" = "pstore" ] && [ "${CRASHK}" -ne 0 ]; then @@ -166,6 +166,6 @@ fi if ! kexec -s -p "${VMLINUX#*BOOT_IMAGE=}" --initrd "${INITRD_FNAME}" --append="${KDUMP_CMDLINE}"; then logger "kdump: kexec load failed" - exit 0 + exit 1 fi logger "kdump: panic kexec loaded successfully" diff --git a/save-dumps.sh b/save-dumps.sh index a4fc039..6d86887 100644 --- a/save-dumps.sh +++ b/save-dumps.sh @@ -30,7 +30,7 @@ rm -f "${KDUMP_MNT}" if [ ! -d "${KDUMP_MAIN_FOLDER}" ]; then logger "kdump: invalid folder (${KDUMP_MAIN_FOLDER}) - aborting..." - exit 0 + exit 1 fi LOGS_FOUND=0