From 45dc6487002134c80d0ce5adab4eb8fef82a4969 Mon Sep 17 00:00:00 2001 From: "Guilherme G. Piccoli" Date: Thu, 10 Nov 2022 14:08:51 -0300 Subject: [PATCH] 20-kdump-steamos.conf: don't panic on RCU stalls I found a small RCU stall in v6.1-rc3 that is quite insignificant, but panick'ed the system. I feel we're in a risk to have it enabled by default, seems better to stay in the "safe" side of the trade-off and eventually lose some report than to panic in meaningless stall and affect user experience. Signed-off-by: Guilherme G. Piccoli --- 20-kdump-steamos.conf | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/20-kdump-steamos.conf b/20-kdump-steamos.conf index 3a7f45b..6c921e7 100644 --- a/20-kdump-steamos.conf +++ b/20-kdump-steamos.conf @@ -10,8 +10,6 @@ kernel.panic_on_oops = 1 -kernel.panic_on_rcu_stall = 1 - kernel.softlockup_panic = 1 kernel.hardlockup_panic = 1 @@ -29,3 +27,9 @@ kernel.panic_print = 71 # Currently disabled, since SteamOS might get stuck while # doing installation on drive using calamares. kernel.hung_task_panic = 0 + +# A bit risky to panic on that, might cause undesirable panics +# due to small stalls. A trade-off is if we indeed have a severe +# bug causing a (long) RCU stall, we'd not panic and have it +# reported. But seems the risk is bigger... +kernel.panic_on_rcu_stall = 0