Zander671/Waybar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
4,798 Commits 1 Branch 0 Tags
fffb4b315970437a419ea7a4de3716afde105328
Commit Graph
412 Commits
Author SHA1 Message Date
Khiet Tam Nguyen 17d7cea4fd Merge branch 'Alexays:master' into hyprland/windowcount 2024-11-17 08:37:04 +11:00
Aqa-Ib 77b50b4c7a fix hyprland's grouped window flags 
Both flags are wrong, because:
- the active group member can be fullscreened.
- technically, a grouped window can be solo as well, because only the active group member is shown, the other members are hidden. Also you can have a group consisting of only one window.
 2024-11-06 13:07:09 +00:00
Victor Perez Cano 552c26497d Merge branch 'master' into hyprland-language-tooltip 2024-10-25 19:00:39 +02:00
Victor Perez Cano 38cf981f78 fixed clang format for language.cpp 2024-10-25 18:58:55 +02:00
Victor Perez Cano 550d108a03 added tooltip-format-<short_description> on hyprland/language tooltip 2024-10-19 17:30:23 +02:00
Victor Perez Cano 696f7e1542 tooltip functionality on hyprland/language module 2024-10-18 20:41:13 +02:00
Christian Fillion 92242f0b9d hyprland: fix a data race at startup between sockets 1 and 2 
`Workspaces::*` and `IPC::startIPC` may both call `getSocketFolder` at the same time.

This randomly causes crashes and/or corruption of the socket path.

Typical crash A:

    [2024-10-16 07:42:09.987] [info] Hyprland IPC starting
    malloc(): unaligned tcache chunk detected
    [2024-10-16 07:42:09.987] [error] Hyprland IPC: Unable to connect?
    Thread 1 "waybar" received signal SIGABRT, Aborted.
    (gdb) bt
    #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
    (omitted for brievety)
    #9  0x00007ffff64ae745 in operator new (sz=sz@entry=296) at /usr/src/debug/gcc/gcc/libstdc++-v3/libsupc++/new_op.cc:50
    #10 0x00007ffff65ab1f1 in std::filesystem::__cxx11::path::_List::_Impl::copy (this=0x555555a23350) at /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++17/fs_path.cc:249
    #11 0x00007ffff65ab3bd in std::filesystem::__cxx11::path::_List::_List (this=0x7fffffff9d30, other=<optimized out>) at /usr/src/debug/gcc/gcc-build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/unique_ptr.h:454
    #12 0x00005555556f4ab1 in waybar::modules::hyprland::IPC::getSocket1Reply(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
    #13 0x00005555556f5e3d in waybar::modules::hyprland::IPC::getSocket1JsonReply(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
    #14 0x000055555571289c in waybar::modules::hyprland::Workspaces::setCurrentMonitorId() ()

Typical crash B:

    [2024-10-16 10:01:15.859] [info] Hyprland IPC starting
    [2024-10-16 10:01:15.859] [info] Loading persistent workspaces from Hyprland workspace rules
    Thread 8 "waybar" received signal SIGSEGV, Segmentation fault.
    (gdb) bt
    #0  std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_S_copy
        (__d=0x5555558fbca8 "/", __s=0x2973961a26d35726 <error: Cannot access memory at address 0x2973961a26d35726>, __n=1)
        at /usr/src/debug/gcc/gcc-build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/basic_string.h:433
    (omitted for brievety)
    #15 waybar::modules::hyprland::IPC::getSocketFolder[abi:cxx11](char const*)
        (instanceSig=0x7fffffffe604 "4520b30d498daca8079365bdb909a8dea38e8d55_1729051218_1982280648") at ../src/modules/hyprland/backend.cpp:41
    #16 0x000055555564230f in waybar::modules::hyprland::IPC::startIPC()::{lambda()#1}::operator()() const ()
        at ../src/modules/hyprland/backend.cpp:70
    #17 0x00007ffff64e1c34 in std::execute_native_thread_routine (__p=0x5555558119c0) at /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++11/thread.cc:104
    #18 0x00007ffff62a339d in start_thread (arg=<optimized out>) at pthread_create.c:447
 2024-10-17 06:46:07 -04:00
Khiet Tam Nguyen 4cb2bf06b7 Merge branch 'Alexays:master' into hyprland/windowcount 2024-09-14 13:42:04 +10:00
Alex 6417782af6 chore: lint 2024-09-13 08:55:14 +02:00
Khiet Tam Nguyen 13bc497abd style: clang-format 2024-08-24 15:21:04 +10:00
Khiet Tam Nguyen 8254bd72b7 style: applied clang-format on windowcount.cpp 2024-08-24 13:36:00 +10:00
Khiet Tam Nguyen a5e322ee66 fix: remove rewrite 2024-08-24 12:59:57 +10:00
Khiet Tam Nguyen 6aa8aa3b22 fix: remove focused_ 2024-08-24 12:57:10 +10:00
Khiet Tam Nguyen f7e1d34251 feat: added empty and fullscreen style classes 2024-08-24 01:33:15 +10:00
Khiet Tam Nguyen 38ffb24c52 feat: format-fullscreen and format-windowed override added 2024-08-24 01:25:50 +10:00
Khiet Tam Nguyen 1b282e67a7 fix: remove unused attributes 2024-08-24 01:06:00 +10:00
Khiet Tam Nguyen 1806edcb06 fix: remove unused variable 2024-08-24 01:04:58 +10:00
Khiet Tam Nguyen e40bc27257 fix: default separate-outputs to true 2024-08-24 00:40:41 +10:00
Khiet Tam Nguyen 58e4f89a82 fix: allow custom format 2024-08-24 00:40:22 +10:00
Khiet Tam Nguyen d64c80e234 temp: working implementation 2024-08-24 00:14:30 +10:00
Khiet Tam Nguyen 5c859bf520 temp: changed window -> windowcount 2024-08-24 00:06:24 +10:00
Aleksei Bavshin 1f23b30b56 hyprland/backend: drop unnecessary getaddrinfo call 
Hyprland hasn't been using TCP sockets for IPC since the first release,
so this getaddrinfo call and its result was never needed.

Additionally, it leaks the `aiRes`, causing test failure under ASan.
 2024-08-17 22:32:17 -07:00
Austin Horstman 4295faa7c4 hyprland/backend: throw runtime_error instead of log 
Allows us to disable modules entirely when socket connection isn't
working. This is similar to how sway handles their socket connections
disabling modules. This supports a single waybar config for multiple
IPCs.
 2024-07-16 18:40:47 -05:00
Austin Horstman b41fcdedff hyprland/window: fix crash when no return from socket 
Gracefully handle lack of response from the IPC. If socket isn't
available, we already log the IPC isn't running. We dont need to crash
program just because we couldn't get responses. We can just return an
empty object.
 2024-07-15 09:02:27 -05:00
Austin Horstman 702e10649e modules/hyprland/workspace: ignore empty window-rewrite 
I'd like to ignore some windows from having icons or empty space taken
on the bar. By filtering out empty repr we can supply rewrite rules that
will ignore them from being processed and showing an empty space or
default icon.
 2024-07-03 00:21:49 -05:00
Alexis Rouillard 47db2db2c8 Merge branch 'master' into hyprland-window_no_title_from_special 2024-07-02 23:19:39 +02:00
Alexis Rouillard ff0f408ab8 Merge pull request #3380 from alerque/debug-keyboard-layout 
Add keyboard debug info to hyprland language module
 2024-07-01 09:22:08 +02:00
Austin Horstman c08660d837 modules/hyprland/backend: handle empty json responses 
Fixes https://github.com/Alexays/Waybar/issues/3388
 2024-06-28 13:18:44 -05:00
Austin Horstman f6482c36dc hyprland: clangd cleanup 2024-06-28 13:06:14 -05:00
Caleb Maclennan 4126502fe8 Add debug information for keyboard layout selection 2024-06-23 00:02:48 +03:00
Austin Horstman f9e693b2a2 modules/hyprland/backend: remove testing log warn 2024-06-15 18:37:25 -05:00
Austin Horstman bac4d03813 modules/hyprland/workspaces: remove deprecated property 2024-06-15 18:34:45 -05:00
Alex 0bc43c1aa7 fix: lint 2024-06-12 23:08:27 +02:00
Austin Horstman 959422f143 modules/hyprland/backend: protect against crash when XDG_RUNTIME_DIR not set 2024-06-09 10:18:20 -05:00
Austin Horstman fa2e21dfd5 modules/hyprland/backend: move getSocketFolder to class 2024-06-09 10:18:20 -05:00
Austin Horstman 0055ee6910 modules/hyprland/workspaces: remove unneccesary visibleWorkspaces variable 2024-06-07 13:56:49 -05:00
Alexis Rouillard 9332697ec1 Merge pull request #3064 from alttabber/master 
Hyprland/Workspaces: Added option to hide non-visible special workspaces
 2024-05-29 10:23:26 +02:00
Austin Horstman 24e8766aaa hyprland/backend: use /tmp 
Was hardcoded to /tmp in previous versions
 2024-05-28 11:00:20 -05:00
alttabber 29e3d8c371 Hide non-visible special workspaces 2024-05-28 17:45:01 +02:00
Austin Horstman f5bb086460 hyprland/workspaces: sort methods 2024-05-24 14:41:59 -05:00
Austin Horstman 9ba9d57c8c hyprland/windowcreationpayload: sort methods 2024-05-24 14:30:31 -05:00
Austin Horstman 82ae474002 hyprland/workspace: sort methods 2024-05-24 14:29:03 -05:00
Austin Horstman 56319a4705 hyprland/workspaces: break up implementations 2024-05-24 14:21:31 -05:00
Austin Horstman d73051e980 hyprland/workspaces: break up doUpdate 2024-05-24 14:21:31 -05:00
Austin Horstman 9fe51af6b0 hyprland/workspaces: break up parseConfig 2024-05-24 14:21:31 -05:00
yangyingchao b8e68b0e63 (hyprland) fix crash when failed to parse IPC message 
IPC messages are parsed in a dedicated thread, and the thread terminates when
an exception is not caught, which causes the waybar process to crash with
SIGABORT.

While this issue might be related to Hyprland, it is really annoying to see
waybar crash. It would be better to catch those exceptions and report errors
instead of crashing.
 2024-05-22 12:52:01 +08:00
Tuur Vanhoutte 29917fb073 Fix hyprland/language events not working with keyboard names with commas in them (#3224) 2024-05-07 08:26:05 +02:00
Tuur Vanhoutte f41458ea24 Fix Hyprland socketpath changed to XDG_RUNTIME_DIR (#3183) 2024-04-29 19:46:28 +02:00
Tom Benham 084b561d5b [hyprland/workspaces] Update window count and sort workspaces AFTER their creation 2024-04-12 11:40:05 +02:00
Tom Benham cd3d588abd [hyprland/workspaces] Fix active workspace not getting updated on multi monitor setups 2024-04-12 11:33:29 +02:00