 Viktar Lukashonak
|
5c979152de
|
refactor(cava): fix thread-safety, resource leaks, and style violations
Comprehensive refactor of the cava module backend and frontends.
Style & naming
- Rename Cava -> CavaRaw; snake_case methods -> lowerCamelCase
- Replace NULL with nullptr; replace C-style casts with static_cast
- Add explicit standard-library includes (<memory>, <string>, <chrono>)
- Fix missing trailing underscores on member variables
Architecture
- Remove Gtk::GLArea multiple inheritance in CavaGLSL (composition)
- Return std::unique_ptr from factory; add doAction() to GLSL variant
- Encapsulate thread timing arithmetic in AdaptiveDelay struct
Thread safety & correctness
- Replace raw sigc::signal with SafeSignal for cross-thread marshalling
- Fix data race between loadConfig() and out_thread_ (recursive_mutex)
- Fix audio_raw shallow-copy use-after-free via deep-copy AudioRaw payload
- Make loadConfig() exception-safe with CavaConfigGuard RAII
- Fix blocking read_thread_ race on shutdown (condition_variable + timeout join)
- Fix isSilent() data race (acquire pthread mutex)
- Eliminate doUpdate() recursion (iteration instead)
- Guard audio_raw_clean() against uninitialized state
- Fix format-icons underflow and cava_config buffer overflow
- Store config by value to prevent dangling references on reload
- Cache frontend config and refresh on runtime changes
- Fix signed-char icon lookup bug on x86
- Prevent Json::Value mutation bloat via const-ref lookups
- Broaden exception catches in worker threads (std::exception)
Resource management & GL robustness
- Fix OpenGL resource leaks (persist VBO/IBO/VAO; explicit destructor cleanup)
- Fix shader error handling crashes (valid infoLog allocation)
- Cache uniform locations instead of querying per frame
- Fix gradient color uninitialized stack memory (zero-init + clamped count)
- Fix shader time uniform integer division bug (float arithmetic)
- Add explicit VAO bind in onRender()
- Handle runtime surface config changes independently of shader changes
- Clamp negative gradient_count before GL upload
Follow-up
- Singleton API split (inst() + configure()) intentionally deferred to a
dedicated PR because it changes the public constructor contract.
|
2026-07-13 19:50:09 +03:00 |
|
|
Xavier Ruiz
|
e3186abdce
|
fix(cava): handle all output methods in frontend
Default to raw Cava module for non-GLSL output methods.
Fixes "Unknown module" error when no cava_config is specified.
|
2025-12-27 14:52:28 -05:00 |
|
|
Viktar Lukashonak
|
e03119fe94
|
Factory. cava_frontend
|
2025-12-09 18:13:45 +03:00 |
|
|
Viktar Lukashonak
|
3773021546
|
cavaGLSL
|
2025-12-07 23:08:55 +03:00 |
|
|
Viktar Lukashonak
|
52f4db1154
|
Moving GTK dispatcher into frontend
|
2025-12-05 10:04:52 +03:00 |
|
|
Viktar Lukashonak
|
13519ca5bf
|
cava. nonsafe thread.= & cava bump
|
2025-11-26 13:26:32 +03:00 |
|
|
Viktar Lukashonak
|
966da11f3b
|
cava bump & fixing memory leaks
|
2025-10-12 14:53:49 +03:00 |
|
|
Viktar Lukashonak
|
76d3b47ffd
|
Cava back/front end transformation
|
2025-09-26 23:34:11 +03:00 |
|