Zander671/Waybar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

memory leak: 2nd attempt

Browse Source
This commit is contained in:
Rene D. Obermueller
2025-05-03 11:26:03 +02:00
parent 72184b2205
commit ff4ed82693
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/modules/privacy/privacy_item.cpp
View File

@ -100,12 +100,15 @@ void PrivacyItem::update_tooltip() {
// Removes all old nodes // Removes all old nodes
for (auto *child : tooltip_window.get_children()) { for (auto *child : tooltip_window.get_children()) {
tooltip_window.remove(*child); tooltip_window.remove(*child);
// despite the remove, still needs a delete to prevent memory leak. Speculating that this might
// work differently in GTK4.
delete child;
} }
for (auto *node : *nodes) { for (auto *node : *nodes) {
Gtk::Box *box = new Gtk::Box(Gtk::ORIENTATION_HORIZONTAL, 4); auto *box = Gtk::make_managed<Gtk::Box>(Gtk::ORIENTATION_HORIZONTAL, 4);
// Set device icon // Set device icon
Gtk::Image *node_icon = Gtk::make_managed<Gtk::Image>(); auto *node_icon = Gtk::make_managed<Gtk::Image>();
node_icon->set_pixel_size(tooltipIconSize); node_icon->set_pixel_size(tooltipIconSize);
node_icon->set_from_icon_name(node->getIconName(), Gtk::ICON_SIZE_INVALID); node_icon->set_from_icon_name(node->getIconName(), Gtk::ICON_SIZE_INVALID);
box->add(*node_icon); box->add(*node_icon);