Zander671/Waybar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tray): set an accel group on the dbusmenu client to stop Gtk-CRITICAL crash

Browse Source 
When a tray item exports menu accelerators (e.g. Mattermost), libdbusmenu-gtk
calls gtk_widget_set_accel_path() with a NULL accel group because the
DbusmenuGtkClient never had one assigned. This raises a Gtk-CRITICAL that
corrupts menu state, and aborts Waybar when running under
G_DEBUG=fatal-criticals.

Assign a fresh GtkAccelGroup to the client right after the menu is created,
before it is populated or shown.

Fixes #5142.
This commit is contained in:
Alex
2026-07-04 12:50:30 +02:00
parent 33223d5534
commit fae2b311de
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/sni/item.cpp
+9
View File
@@ -577,6 +577,15 @@ void Item::makeMenu() {
if (dbus_menu != nullptr) { if (dbus_menu != nullptr) {
g_object_ref_sink(G_OBJECT(dbus_menu)); g_object_ref_sink(G_OBJECT(dbus_menu));
g_object_weak_ref(G_OBJECT(dbus_menu), (GWeakNotify)onMenuDestroyed, this); g_object_weak_ref(G_OBJECT(dbus_menu), (GWeakNotify)onMenuDestroyed, this);
// Provide an accel group to the dbusmenu client. Without one, items that export menu
// accelerators (e.g. Mattermost) trigger gtk_widget_set_accel_path() with a NULL accel group,
// which raises a Gtk-CRITICAL and corrupts menu state (or aborts under fatal-criticals).
DbusmenuGtkClient* client = dbusmenu_gtkmenu_get_client(DBUSMENU_GTKMENU(dbus_menu));
if (client != nullptr) {
GtkAccelGroup* accel_group = gtk_accel_group_new();
dbusmenu_gtkclient_set_accel_group(client, accel_group);
g_object_unref(accel_group);
}
gtk_menu = Glib::wrap(GTK_MENU(dbus_menu)); gtk_menu = Glib::wrap(GTK_MENU(dbus_menu));
gtk_menu->attach_to_widget(event_box); gtk_menu->attach_to_widget(event_box);
} }