From d61bc859ae7a086abed0f9b93cf69ce7f4e8b3bf Mon Sep 17 00:00:00 2001
From: zspher <66728045+zspher@users.noreply.github.com>
Date: Wed, 29 Oct 2025 17:07:36 -0600
Subject: [PATCH] perf(image): set image from `path` only once

---
 src/modules/image.cpp | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/src/modules/image.cpp b/src/modules/image.cpp
index 8b9888bc..02b6d336 100644
--- a/src/modules/image.cpp
+++ b/src/modules/image.cpp
@@ -28,6 +28,13 @@ waybar::modules::Image::Image(const std::string& id, const Json::Value& config)
     size_ = 16;
   }
 
+  if (config_["path"].isString()) {
+    auto result = Config::tryExpandPath(config_["path"].asString(), "");
+    path_ = result.empty() ? "" : result.front();
+  } else {
+    path_.clear();
+  }
+
   if (interval_.count() == 0) {
     interval_ = std::chrono::milliseconds::max();
   }
@@ -49,19 +56,14 @@ void waybar::modules::Image::refresh(int sig) {
 }
 
 auto waybar::modules::Image::update() -> void {
-  if (config_["path"].isString()) {
-    path_ = config_["path"].asString();
-  } else if (config_["exec"].isString()) {
+  if (config_["exec"].isString()) {
     output_ = util::command::exec(config_["exec"].asString(), "");
     parseOutputRaw();
-  } else {
-    path_ = "";
+    // expand path if "~" or "$HOME" is present in original path
+    auto result = Config::tryExpandPath(path_, "");
+    path_ = result.empty() ? "" : result.front();
   }
 
-  // expand path if "~" or "$HOME" is present in original path
-  auto result = Config::tryExpandPath(path_, "");
-  path_ = result.empty() ? "" : result.front();
-
   if (Glib::file_test(path_, Glib::FILE_TEST_EXISTS)) {
     Glib::RefPtr<Gdk::Pixbuf> pixbuf;