Zander671/Waybar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

network: treat negative/failed link speed as 0

Browse Source 
/sys/class/net/<if>/speed reports -1 with no carrier. Reading it into a
uint32_t wrapped to 4294967295 (without setting failbit), so {linkSpeed}
showed an absurd value. Read into int64_t, check fail(), and treat negative
or failed reads as 0.
This commit is contained in:
Alex
2026-07-05 10:13:24 +02:00
parent c9012c4107
commit b17743ff6a
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/network.cpp
+6 -3
View File
@@ -90,13 +90,16 @@ uint32_t waybar::modules::Network::readLinkSpeed() const {
if (!sysfs_speed) return 0; if (!sysfs_speed) return 0;
uint32_t speed; // Read into a signed type: /sys/class/net/<if>/speed reports -1 when there is
// no carrier. Extracting -1 into an unsigned type would wrap to a huge value
// (and would not set failbit), so use a signed type and validate the result.
int64_t speed = 0;
sysfs_speed >> speed; sysfs_speed >> speed;
if (sysfs_speed.bad()) // read fails on incompatible devices if (sysfs_speed.fail() || speed < 0) // read fails on incompatible devices
return 0; return 0;
return speed; return static_cast<uint32_t>(speed);
} }
waybar::modules::Network::Network(const std::string& id, const Json::Value& config) waybar::modules::Network::Network(const std::string& id, const Json::Value& config)