Zander671/Waybar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #4207 from markx86/fix/mpris

Browse Source 
fix: MPRIS widget not hiding when no player is active
This commit is contained in:
Alexis Rouillard
2025-06-22 08:23:09 +01:00
committed by GitHub
parent 7d5905b38c c266befe0a
commit 7b9db134dd
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/modules/mpris/mpris.cpp
View File

@ -425,9 +425,11 @@ auto Mpris::onPlayerNameVanished(PlayerctlPlayerManager* manager, PlayerctlPlaye
auto* mpris = static_cast<Mpris*>(data); auto* mpris = static_cast<Mpris*>(data);
if (!mpris) return; if (!mpris) return;
spdlog::debug("mpris: player-vanished callback: {}", player_name->name); spdlog::debug("mpris: name-vanished callback: {}", player_name->name);
if (std::string(player_name->name) == mpris->player_) { if (mpris->player_ == "playerctld") {
mpris->dp.emit();
} else if (mpris->player_ == player_name->name) {
mpris->player = nullptr; mpris->player = nullptr;
mpris->event_box_.set_visible(false); mpris->event_box_.set_visible(false);
mpris->dp.emit(); mpris->dp.emit();
@ -499,6 +501,7 @@ auto Mpris::getPlayerInfo() -> std::optional<PlayerInfo> {
// https://github.com/altdesktop/playerctl/blob/b19a71cb9dba635df68d271bd2b3f6a99336a223/playerctl/playerctl-common.c#L248-L249 // https://github.com/altdesktop/playerctl/blob/b19a71cb9dba635df68d271bd2b3f6a99336a223/playerctl/playerctl-common.c#L248-L249
players = g_list_first(players); players = g_list_first(players);
if (players) player_name = static_cast<PlayerctlPlayerName*>(players->data)->name; if (players) player_name = static_cast<PlayerctlPlayerName*>(players->data)->name;
else return std::nullopt; // no players found, hide the widget
} }
if (std::any_of(ignored_players_.begin(), ignored_players_.end(), if (std::any_of(ignored_players_.begin(), ignored_players_.end(),