Zander671/Waybar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Issue 3981: try and fix memory leak

Browse Source
This commit is contained in:
Rene D. Obermueller
2025-05-02 09:53:11 +02:00
parent 0332d2ebf8
commit 72184b2205
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/modules/privacy/privacy_item.cpp
View File

@ -1,5 +1,7 @@
#include "modules/privacy/privacy_item.hpp" #include "modules/privacy/privacy_item.hpp"
#include <spdlog/spdlog.h>
#include <string> #include <string>
#include "glibmm/main.h" #include "glibmm/main.h"
@ -94,22 +96,22 @@ PrivacyItem::PrivacyItem(const Json::Value &config_, enum PrivacyNodeType privac
} }
void PrivacyItem::update_tooltip() { void PrivacyItem::update_tooltip() {
spdlog::trace("update privacy tooltip");
// Removes all old nodes // Removes all old nodes
for (auto *child : tooltip_window.get_children()) { for (auto *child : tooltip_window.get_children()) {
delete child; tooltip_window.remove(*child);
} }
for (auto *node : *nodes) { for (auto *node : *nodes) {
Gtk::Box *box = new Gtk::Box(Gtk::ORIENTATION_HORIZONTAL, 4); Gtk::Box *box = new Gtk::Box(Gtk::ORIENTATION_HORIZONTAL, 4);
// Set device icon // Set device icon
Gtk::Image *node_icon = new Gtk::Image(); Gtk::Image *node_icon = Gtk::make_managed<Gtk::Image>();
node_icon->set_pixel_size(tooltipIconSize); node_icon->set_pixel_size(tooltipIconSize);
node_icon->set_from_icon_name(node->getIconName(), Gtk::ICON_SIZE_INVALID); node_icon->set_from_icon_name(node->getIconName(), Gtk::ICON_SIZE_INVALID);
box->add(*node_icon); box->add(*node_icon);
// Set model // Set model
auto *nodeName = new Gtk::Label(node->getName()); auto *nodeName = Gtk::make_managed<Gtk::Label>(node->getName());
box->add(*nodeName); box->add(*nodeName);
tooltip_window.add(*box); tooltip_window.add(*box);