From 0c3e82219f2ef1217b8c9a4a6092fe2ff01a7b78 Mon Sep 17 00:00:00 2001
From: peelz <peelz.dev@gmail.com>
Date: Tue, 16 Sep 2025 14:03:45 -0400
Subject: [PATCH] fix: close sni menu on item destruction

---
 include/modules/sni/item.hpp | 2 +-
 src/modules/sni/item.cpp     | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/include/modules/sni/item.hpp b/include/modules/sni/item.hpp
index c5e86d37..503ab637 100644
--- a/include/modules/sni/item.hpp
+++ b/include/modules/sni/item.hpp
@@ -26,7 +26,7 @@ struct ToolTip {
 class Item : public sigc::trackable {
  public:
   Item(const std::string&, const std::string&, const Json::Value&, const Bar&);
-  ~Item() = default;
+  ~Item();
 
   std::string bus_name;
   std::string object_path;
diff --git a/src/modules/sni/item.cpp b/src/modules/sni/item.cpp
index 4e80eba7..30a6b834 100644
--- a/src/modules/sni/item.cpp
+++ b/src/modules/sni/item.cpp
@@ -74,6 +74,13 @@ Item::Item(const std::string& bn, const std::string& op, const Json::Value& conf
                                    cancellable_, interface);
 }
 
+Item::~Item() {
+  if (this->gtk_menu != nullptr) {
+    this->gtk_menu->popdown();
+    this->gtk_menu->detach();
+  }
+}
+
 bool Item::handleMouseEnter(GdkEventCrossing* const& e) {
   event_box.set_state_flags(Gtk::StateFlags::STATE_FLAG_PRELIGHT);
   return false;